flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3034) Redis SInk Connector
Date Sun, 19 Jun 2016 19:01:05 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338700#comment-15338700
] 

ASF GitHub Bot commented on FLINK-3034:
---------------------------------------

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1813#discussion_r67622080
  
    --- Diff: flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/common/config/JedisPoolConfig.java
---
    @@ -0,0 +1,275 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.streaming.connectors.redis.common.config;
    +
    +import com.google.common.base.Preconditions;
    +import org.apache.commons.pool2.impl.GenericObjectPoolConfig;
    +import redis.clients.jedis.Protocol;
    +
    +import java.io.Serializable;
    +
    +/**
    + * Configuration for Jedis Pool.
    + */
    +public class JedisPoolConfig implements Serializable {
    +
    +	private static final long serialVersionUID = 1L;
    +
    +	private String host;
    +	private int port;
    +	private int timeout;
    +	private int database;
    +	private String password;
    +	private int maxTotal;
    +	private int maxIdle;
    +	private int minIdle;
    +
    +	/**
    +	 * The host is mandatory, and when host is not set, it throws NullPointerException.
    +	 *
    +	 * @param host host hostname or IP
    +	 * @param port port port
    +	 * @param timeout timeout socket / connection timeout
    +	 * @param password password password, if any
    +	 * @param database database database index
    +	 * @param maxTotal maxTotal the maximum number of objects that can be allocated by the
pool
    +	 * @param maxIdle the cap on the number of "idle" instances in the pool
    +     * @param minIdle the minimum number of idle objects to maintain in the pool
    +	 * @throws NullPointerException if do not see host
    +     */
    +	private JedisPoolConfig(String host, int port, int timeout, String password, int database,
    +							int maxTotal, int maxIdle, int minIdle) {
    +		Preconditions.checkNotNull(host, "Host information should be presented");
    +		this.host = host;
    +		this.port = port;
    +		this.timeout = timeout;
    +		this.database = database;
    +		this.password = password;
    +		this.maxTotal = maxTotal;
    +		this.maxIdle = maxIdle;
    +		this.minIdle = minIdle;
    +	}
    +
    +	/**
    +	 * Get the value for the {@code maxTotal} configuration attribute
    +	 * for pools to be created with this configuration instance.
    +	 *
    +	 * @return  The current setting of {@code maxTotal} for this
    +	 *          configuration instance
    +	 * @see GenericObjectPoolConfig#getMaxTotal()
    +	 */
    +	public int getMaxTotal() {
    +		return maxTotal;
    +	}
    +
    +	/**
    +	 * Get the value for the {@code maxIdle} configuration attribute
    +	 * for pools to be created with this configuration instance.
    +	 *
    +	 * @return  The current setting of {@code maxIdle} for this
    +	 *          configuration instance
    +	 * @see GenericObjectPoolConfig#getMaxIdle()
    +	 */
    +	public int getMaxIdle() {
    +		return maxIdle;
    +	}
    +
    +	/**
    +	 * Get the value for the {@code minIdle} configuration attribute
    +	 * for pools to be created with this configuration instance.
    +	 *
    +	 * @return  The current setting of {@code minIdle} for this
    +	 *          configuration instance
    +	 * @see GenericObjectPoolConfig#getMinIdle()
    +	 */
    +	public int getMinIdle() {
    +		return minIdle;
    +	}
    +
    +	/**
    +	 * Returns host.
    +	 *
    +	 * @return hostname or IP
    +	 */
    +	public String getHost() {
    +		return host;
    +	}
    +
    +	/**
    +	 * Returns port.
    +	 *
    +	 * @return port
    +	 */
    +	public int getPort() {
    +		return port;
    +	}
    +
    +	/**
    +	 * Returns timeout.
    +	 *
    +	 * @return socket / connection timeout
    +	 */
    +	public int getTimeout() {
    +		return timeout;
    +	}
    +
    +	/**
    +	 * Returns database index.
    +	 *
    +	 * @return database index
    +	 */
    +	public int getDatabase() {
    +		return database;
    +	}
    +
    +	/**
    +	 * Returns password.
    +	 *
    +	 * @return password
    +	 */
    +	public String getPassword() {
    +		return password;
    +	}
    +
    +	/**
    +	 * Builder for initializing JedisPoolConfig.
    --- End diff --
    
    Nit: {@link JedisPoolConfig} or {


> Redis SInk Connector
> --------------------
>
>                 Key: FLINK-3034
>                 URL: https://issues.apache.org/jira/browse/FLINK-3034
>             Project: Flink
>          Issue Type: New Feature
>          Components: Streaming Connectors
>            Reporter: Matthias J. Sax
>            Assignee: Subhankar Biswas
>            Priority: Minor
>
> Flink does not provide a sink connector for Redis.
> See FLINK-3033



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message