flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1550) Show JVM Metrics for JobManager
Date Wed, 22 Jun 2016 14:07:57 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344350#comment-15344350
] 

ASF GitHub Bot commented on FLINK-1550:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2146#discussion_r68058991
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
    @@ -149,6 +154,9 @@ class JobManager(
     
       var leaderSessionID: Option[UUID] = None
     
    +  private var metricsRegistry : FlinkMetricRegistry = _
    --- End diff --
    
    So far, we've created the JobManager's components outside of the JobManager and passed
them to it as a constructor argument. This had the advantage that if one of the components
failed, it would not cause the `JobManager` to fail and the actor to die. But instead we could
fail early telling exactly where the problem occurred.
    
    Maybe we could do the same for the `FlinkMetricRegistry`.


> Show JVM Metrics for JobManager
> -------------------------------
>
>                 Key: FLINK-1550
>                 URL: https://issues.apache.org/jira/browse/FLINK-1550
>             Project: Flink
>          Issue Type: Sub-task
>          Components: JobManager, Metrics
>            Reporter: Robert Metzger
>            Assignee: Chesnay Schepler
>             Fix For: pre-apache
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message