flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2149: [FLINK-4084] Add configDir parameter to CliFronten...
Date Thu, 30 Jun 2016 12:33:28 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2149#discussion_r69123278
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
---
    @@ -459,4 +476,14 @@ public static InfoOptions parseInfoCommand(String[] args) throws
CliArgsExceptio
     		}
     	}
     
    +	public static MainOptions parseMainCommand(String[] args) throws CliArgsException {
    +		try {
    +			DefaultParser parser = new DefaultParser();
    +			CommandLine line = parser.parse(MAIN_OPTIONS, args, false);
    --- End diff --
    
    You're parsing the entire arguments here. What if the user jar has `--configDir` as parameter?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message