flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request #2177: [FLINK-4127] Check API compatbility for 1.1 in fli...
Date Wed, 29 Jun 2016 08:39:02 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2177#discussion_r68905853
  
    --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java
---
    @@ -269,26 +269,26 @@
     	 * Percentage of heap space to remove from containers (YARN / Mesos), to compensate
     	 * for other JVM memory usage.
     	 */
    -	public static final String CONTAINERED_HEAP_CUTOFF_RATIO = "containered.heap-cutoff-ratio";
    +	public static final String CONTAINER_HEAP_CUTOFF_RATIO = "container.heap-cutoff-ratio";
     
     	/**
     	 * Minimum amount of heap memory to remove in containers, as a safety margin.
     	 */
    -	public static final String CONTAINERED_HEAP_CUTOFF_MIN = "containered.heap-cutoff-min";
    +	public static final String CONTAINER_HEAP_CUTOFF_MIN = "container.heap-cutoff-min";
     
     	/**
     	 * Prefix for passing custom environment variables to Flink's master process.
     	 * For example for passing LD_LIBRARY_PATH as an env variable to the AppMaster, set:
     	 * yarn.application-master.env.LD_LIBRARY_PATH: "/usr/lib/native"
     	 * in the flink-conf.yaml.
     	 */
    -	public static final String CONTAINERED_MASTER_ENV_PREFIX = "containered.application-master.env.";
    +	public static final String CONTAINER_MASTER_ENV_PREFIX = "container.application-master.env.";
    --- End diff --
    
    How about we rename the config string to `container.master.env`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message