flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From greghogan <...@git.apache.org>
Subject [GitHub] flink issue #1517: [FLINK-3477] [runtime] Add hash-based combine strategy fo...
Date Tue, 28 Jun 2016 17:57:57 GMT
Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/1517
  
    +1 with just a few superficial comments.
    
    Reading back through the discussion I see that there are many ideas for future performance
enhancements. If not already suggested I'd like to consider skipping staging for fixed length
records.
    
    I'm missing why we can't update in place with smaller records. The deserializer is responsible
for detecting the end of the record and we wouldn't need to change the pointer value when
replacing with a smaller record.
    
    CombineHint.NONE can be implemented in a new PR since this looks to be ready as-is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message