flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...
Date Tue, 28 Jun 2016 09:57:25 GMT
Github user rmetzger commented on a diff in the pull request:

    --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
    @@ -155,55 +199,79 @@ public GetRecordsResult getRecords(String shardIterator, int maxRecordsToGet)
     	 * @param startingSeqNum the sequence number that the iterator will start from
     	 * @return the shard iterator
    +	@Override
     	public String getShardIterator(KinesisStreamShard shard, String shardIteratorType, String
startingSeqNum) {
    -		return kinesisClient.getShardIterator(shard.getStreamName(), shard.getShardId(), shardIteratorType,
    +		return kinesisClient.getShardIterator(shard.getStreamName(), shard.getShard().getShardId(),
shardIteratorType, startingSeqNum).getShardIterator();
    --- End diff --
    Yes, I think we should have retries there as well. In particular during start up, many
parallel Flink instances will query AWS for the shard iterator.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message