flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request #2131: [FLINK-3231][streaming-connectors] FlinkKinesisCon...
Date Fri, 24 Jun 2016 13:42:31 GMT
Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2131#discussion_r68399467
  
    --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
---
    @@ -122,29 +173,36 @@ public GetRecordsResult getRecords(String shardIterator, int maxRecordsToGet)
{
     	}
     
     	/**
    -	 * Get the list of shards associated with multiple Kinesis streams
    +	 * Get the complete shard list of multiple Kinesis streams.
     	 *
    -	 * @param streamNames the list of Kinesis streams
    -	 * @return a list of {@link KinesisStreamShard}s
    +	 * @param streamNames Kinesis streams to retrieve the shard list for
    +	 * @return shard list result
     	 */
    -	public List<KinesisStreamShard> getShardList(List<String> streamNames) {
    -		List<KinesisStreamShard> shardList = new ArrayList<>();
    +	public GetShardListResult getShardList(List<String> streamNames) throws InterruptedException
{
    +		GetShardListResult result = new GetShardListResult();
     
     		for (String stream : streamNames) {
    -			DescribeStreamResult describeStreamResult;
    -			String lastSeenShardId = null;
    +			result.addRetrievedShardsToStream(stream, getShardsOfStream(stream, null));
    +		}
    +		return result;
    +	}
     
    -			do {
    -				describeStreamResult = describeStream(stream, lastSeenShardId);
    +	/**
    +	 * Get shard list of multiple Kinesis streams, ignoring the
    +	 * shards of each streambefore a specified last seen shard id.
    +	 *
    +	 * @param streamNamesWithLastSeenShardIds a map with stream as key, and last seen shard
id as value
    +	 * @return shard list result
    +	 */
    +	public GetShardListResult getShardList(Map<String,String> streamNamesWithLastSeenShardIds)
throws InterruptedException {
    --- End diff --
    
    Missing `@Override` annotation


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message