flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink issue #2096: [FLINK-3800] [runtime] Introduce SUSPENDED job status
Date Thu, 23 Jun 2016 13:09:47 GMT
Github user tillrohrmann commented on the issue:

    Thanks for your thorough review @uce.
    - We have talked offline concerning the status in the web interface and it turned out
to be not a problem since the jobs are directly removed from `currentJobs` in the `JobManager`
when `cancelAndClearEverything` is called. This implies that the jobs will no longer be shown
in the web interface.
    - I agree that it is a good idea to replace the `SuppressRestartException` by a mechanism
to disable the `RestartStrategies`. I've opened a [JIRA issue](https://issues.apache.org/jira/browse/FLINK-4112)
to keep track of the effort. I think, however, that the mechanism should be implemented as
part of the work on this issue. That way we won't mix pull requests with each other.
    - You're right. I've addressed the comment and added `SUSPENDED` to the set of states
which don't throw an exception when encountered in `ExecutionGraph.restart`.
    - You're right concerning the `JobManagerProcess` tests. Maybe we can refactor some of
them in the future by applying a similar pattern as it was used in `JobManagerHARecoveryTest`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message