flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #2146: [FLINK-1550/FLINK-4057] Add JobManager Metrics
Date Wed, 22 Jun 2016 14:07:55 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2146#discussion_r68058991
  
    --- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
    @@ -149,6 +154,9 @@ class JobManager(
     
       var leaderSessionID: Option[UUID] = None
     
    +  private var metricsRegistry : FlinkMetricRegistry = _
    --- End diff --
    
    So far, we've created the JobManager's components outside of the JobManager and passed
them to it as a constructor argument. This had the advantage that if one of the components
failed, it would not cause the `JobManager` to fail and the actor to die. But instead we could
fail early telling exactly where the problem occurred.
    
    Maybe we could do the same for the `FlinkMetricRegistry`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message