flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #1962: [FLINK-3857][Streaming Connectors]Add reconnect at...
Date Mon, 20 Jun 2016 05:28:13 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1962#discussion_r67637714
  
    --- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
---
    @@ -166,30 +265,37 @@ public void open(Configuration configuration) {
     			transportClient.addTransportAddress(transport);
     		}
     
    -		// verify that we actually are connected to a cluster
    +		return transportClient;
    +	}
    +
    +	private boolean checkConnectionStatus(TransportClient transportClient) {
    --- End diff --
    
    Static would be better for utility function that will be called a lot.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message