flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjsax <...@git.apache.org>
Subject [GitHub] flink pull request #1813: [FLINK-3034] Redis Sink Connector
Date Sun, 19 Jun 2016 19:40:46 GMT
Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1813#discussion_r67622635
  
    --- Diff: flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java
---
    @@ -0,0 +1,221 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.streaming.connectors.redis;
    +
    +import org.apache.flink.api.java.tuple.Tuple2;
    +import org.apache.flink.streaming.api.datastream.DataStreamSource;
    +import org.apache.flink.streaming.api.environment.StreamExecutionEnvironment;
    +import org.apache.flink.streaming.api.functions.source.SourceFunction;
    +import org.apache.flink.streaming.connectors.redis.common.config.JedisClusterConfig;
    +import org.apache.flink.streaming.connectors.redis.common.config.JedisPoolConfig;
    +import org.apache.flink.streaming.connectors.redis.common.mapper.RedisDataType;
    +import org.apache.flink.streaming.connectors.redis.common.mapper.RedisDataTypeDescription;
    +import org.apache.flink.streaming.connectors.redis.common.mapper.RedisMapper;
    +import org.junit.After;
    +import org.junit.Before;
    +import org.junit.Test;
    +import redis.clients.jedis.Jedis;
    +
    +import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertNull;
    +
    +public class RedisSinkTest extends RedisTestBase {
    +
    +	private JedisPoolConfig jedisPoolConfig;
    +	private static final Long NUM_ELEMENTS = 20L;
    +	private static final String REDIS_KEY = "TEST_KEY";
    +	private static final String REDIS_ADDITIONAL_KEY = "TEST_ADDITIONAL_KEY";
    +
    +	StreamExecutionEnvironment env;
    --- End diff --
    
    Why do you use a single `env` for all test. I think it would be better to have test local
`env`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message