flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #1856: FLINK-3650 Add maxBy/minBy to Scala DataSet API
Date Wed, 15 Jun 2016 12:04:55 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java ---
    @@ -521,7 +521,7 @@ public long count() throws Exception {
     		return new ReduceOperator<>(this, new SelectByMinFunction(
    -				(TupleTypeInfo) getType(), fields), Utils.getCallLocationName());
    --- End diff --
    Can you please revert these style changes as well? We try to avoid touching files without
a real need. Thanks

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message