flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] flink pull request #2090: Expose several new Metrics
Date Wed, 15 Jun 2016 06:39:15 GMT
Github user zentol commented on a diff in the pull request:

    --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/FileSourceFunction.java
    @@ -123,9 +127,11 @@ public void run(SourceContext<OUT> ctx) throws Exception {
     			OUT nextElement = serializer.createInstance();
     			nextElement =  format.nextRecord(nextElement);
     			if (nextElement == null && splitIterator.hasNext()) {
    +				splitCounter.inc();
    --- End diff --
    the behaviour in both classed is the same. If the format returns null it is considered
empty (==completed), hence we increase the counter.
    well the FIleSourceFunction doesn't properly call close() once the split was processed.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message