flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #1962: [FLINK-3857][Streaming Connectors]Add reconnect at...
Date Thu, 09 Jun 2016 06:27:06 GMT
Github user tzulitai commented on a diff in the pull request:

    --- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java
    @@ -153,9 +165,90 @@ public ElasticsearchSink(Map<String, String> userConfig, List<InetSocketAddress>
     	public void open(Configuration configuration) {
    +		connect();
    --- End diff --
    I think we should try to avoid side-effecting class field members within utility member
functions. It reduces the readability of the code. Return the created TransportClient instead,
and have a separate utility function to check if connection is lost?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message