flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From techmaniack <...@git.apache.org>
Subject [GitHub] flink pull request #2066: Updated ssh configuration in base Dockerfile
Date Mon, 06 Jun 2016 11:14:24 GMT
Github user techmaniack commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2066#discussion_r65873361
  
    --- Diff: flink-contrib/docker-flink/base/Dockerfile ---
    @@ -38,12 +38,12 @@ ENV JAVA_HOME /usr/java/default/
     RUN echo 'root:secret' | chpasswd
     
     #SSH as root... probably needs to be revised for security!
    -RUN sed -i 's/PermitRootLogin without-password/PermitRootLogin yes/' /etc/ssh/sshd_config
    --- End diff --
    
    Agreed. It might break previous ubuntu versions workflow.
    Changing the sed expression to the following works for precise/trusty/xenial
    
    `sed -i 's/PermitRootLogin .*/PermitRootLogin yes/' /etc/ssh/sshd_config`
    
    Also, currently the flink version is hardcoded in a URL in flink/Dockerfile which can
be moved to **install-flink.sh** where flink/scala/hadoop versions can be specified. Something
like this:
    
    ```
    BASE_URL=http://www-us.apache.org/dist/flink/
    FLINK_VERSION=1.0.3
    SCALA_VERSION=2.11
    HADOOP_VERSION=27 #2.7.0
    FULL_URL="$BASE_URL/flink-$FLINK_VERSION/flink-$FLINK_VERSION-bin-hadoop$HADOOP_VERSION-scala_$SCALA_VERSION.tgz"
    
    wget -q -O - $FULL_URL | tar -zxvf - -C /usr/local/
    
    cd /usr/local && ln -s "./flink-$FLINK_VERSION" flink
    
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message