Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id A70F72009F8 for ; Thu, 19 May 2016 13:04:14 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id A5A45160A00; Thu, 19 May 2016 11:04:14 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2745C160A04 for ; Thu, 19 May 2016 13:04:13 +0200 (CEST) Received: (qmail 59222 invoked by uid 500); 19 May 2016 11:04:13 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 59039 invoked by uid 99); 19 May 2016 11:04:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 May 2016 11:04:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E88472C1F61 for ; Thu, 19 May 2016 11:04:12 +0000 (UTC) Date: Thu, 19 May 2016 11:04:12 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-3933) Add an auto-type-extracting DeserializationSchema MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 19 May 2016 11:04:14 -0000 [ https://issues.apache.org/jira/browse/FLINK-3933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290904#comment-15290904 ] ASF GitHub Bot commented on FLINK-3933: --------------------------------------- Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/2010#issuecomment-220293226 LGTM except for a minor comment in the doc > Add an auto-type-extracting DeserializationSchema > ------------------------------------------------- > > Key: FLINK-3933 > URL: https://issues.apache.org/jira/browse/FLINK-3933 > Project: Flink > Issue Type: Bug > Components: Streaming > Affects Versions: 1.0.0 > Reporter: Stephan Ewen > Assignee: Stephan Ewen > Fix For: 1.1.0 > > > When creating a {{DeserializationSchema}}, people need to manually worry about how to provide the produced type's {{TypeInformation}}. > We should add a base utility {{AbstractDeserializationSchema}} that provides that automatically via the type extractor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)