Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
Date: Fri, 27 May 2016 13:19:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@flink.apache.org
Message-ID: <JIRA.12919693.1449495309000.316005.1464355152854@Atlassian.JIRA>
In-Reply-To: <JIRA.12919693.1449495309000@Atlassian.JIRA>
References: <JIRA.12919693.1449495309000@Atlassian.JIRA> <JIRA.12919693.1449495309531@arcas>
Subject: [jira] [Commented] (FLINK-3129) Add tooling to ensure interface
 stability
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 27 May 2016 13:19:14 -0000


    [ https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304052#comment-15304052 ] 

ASF GitHub Bot commented on FLINK-3129:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2042#discussion_r64902741
  
    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
    @@ -82,6 +82,10 @@
     
     	private static final long DEFAULT_RESTART_DELAY = 10000L;
     
    +	// This field was used as a key for storing the EC in the Job Configuration
    +	@Deprecated
    +	public static final String CONFIG_KEY = "runtime.config";
    --- End diff --
    
    this change belongs in the "Fix breaking changes in flink-core" commit, unless they will be squashed.


> Add tooling to ensure interface stability
> -----------------------------------------
>
>                 Key: FLINK-3129
>                 URL: https://issues.apache.org/jira/browse/FLINK-3129
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Build System
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
>
> I would like to use this maven plugin: https://github.com/siom79/japicmp to automatically ensure interface stability across minor releases.
> Ideally we have the plugin in place after Flink 1.0 is out, so that maven builds break if a breaking change has been made.
> The plugin already supports downloading a reference release, checking the build and breaking it.
> Not yet supported are class/method inclusions based on annotations, but I've opened a pull request for adding it.
> There are also issues with the resolution of the dependency with the annotations, but I'm working on resolving those issues.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)