Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E8D8D2009C6 for ; Tue, 31 May 2016 11:41:12 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E78F5160A01; Tue, 31 May 2016 09:41:12 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 3AB02160A43 for ; Tue, 31 May 2016 11:41:12 +0200 (CEST) Received: (qmail 38004 invoked by uid 500); 31 May 2016 09:41:11 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 37995 invoked by uid 99); 31 May 2016 09:41:11 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 May 2016 09:41:11 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 038F9C8594 for ; Tue, 31 May 2016 09:41:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx2-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id fNlAIb2XopXF for ; Tue, 31 May 2016 09:41:09 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx2-lw-eu.apache.org (ASF Mail Server at mx2-lw-eu.apache.org) with SMTP id 8DA745FB2C for ; Tue, 31 May 2016 09:41:08 +0000 (UTC) Received: (qmail 37775 invoked by uid 99); 31 May 2016 09:41:07 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 May 2016 09:41:07 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B7488E385C; Tue, 31 May 2016 09:41:06 +0000 (UTC) From: StephanEwen To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request: FLINK-3405: Extend NiFiSource with interface S... Content-Type: text/plain Message-Id: <20160531094107.B7488E385C@git1-us-west.apache.org> Date: Tue, 31 May 2016 09:41:06 +0000 (UTC) archived-at: Tue, 31 May 2016 09:41:13 -0000 Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/2047#issuecomment-222640704 I would do one change here: Make the `isRunning` flag non transient, and set it to true initially, rather than in open. That can act as a safeguard against very early stopping (before open is even completed), were stop would set the flag to false, and open would set it back to true. I think the runtime does prevent open to happen after stop, but cannot hurt to guard this in the source as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---