Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 0099C2007D0 for ; Tue, 10 May 2016 16:51:19 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id F2E5116098A; Tue, 10 May 2016 14:51:18 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 47C50160877 for ; Tue, 10 May 2016 16:51:18 +0200 (CEST) Received: (qmail 38432 invoked by uid 500); 10 May 2016 14:51:17 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 38423 invoked by uid 99); 10 May 2016 14:51:17 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 May 2016 14:51:17 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0DD24180592 for ; Tue, 10 May 2016 14:51:17 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -4.021 X-Spam-Level: X-Spam-Status: No, score=-4.021 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id EXJc2mfeUsH7 for ; Tue, 10 May 2016 14:51:14 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id A998C5F2F0 for ; Tue, 10 May 2016 14:51:13 +0000 (UTC) Received: (qmail 38001 invoked by uid 99); 10 May 2016 14:51:12 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 May 2016 14:51:12 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A514CDFD4C; Tue, 10 May 2016 14:51:12 +0000 (UTC) From: fhueske To: issues@flink.incubator.apache.org Reply-To: issues@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo... Content-Type: text/plain Message-Id: <20160510145112.A514CDFD4C@git1-us-west.apache.org> Date: Tue, 10 May 2016 14:51:12 +0000 (UTC) archived-at: Tue, 10 May 2016 14:51:19 -0000 Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1958#issuecomment-218182019 Hi @yjshen, sorry for the time it took to review the PR. I like the approach and the PR looks good, IMO. I had a few minor comments and questions. Let me know what you think. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---