Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: rmetzger <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1962-flink@git.apache.org>
In-Reply-To: <git-pr-1962-flink@git.apache.org>
Subject: [GitHub] flink pull request: [FLINK-3857][Streaming Connectors]Add reconnec...
Content-Type: text/plain
Message-Id: <20160505105040.D4941DFB90@git1-us-west.apache.org>
Date: Thu,  5 May 2016 10:50:40 +0000 (UTC)
archived-at: Thu, 05 May 2016 10:50:46 -0000

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1962#discussion_r62172571
  
    --- Diff: flink-streaming-connectors/flink-connector-elasticsearch2/src/main/java/org/apache/flink/streaming/connectors/elasticsearch2/ElasticsearchSink.java ---
    @@ -86,6 +88,7 @@
     	public static final String CONFIG_KEY_BULK_FLUSH_MAX_ACTIONS = "bulk.flush.max.actions";
     	public static final String CONFIG_KEY_BULK_FLUSH_MAX_SIZE_MB = "bulk.flush.max.size.mb";
     	public static final String CONFIG_KEY_BULK_FLUSH_INTERVAL_MS = "bulk.flush.interval.ms";
    +	public static final String CONFIG_NO_OF_CONN_RETRIES = "conn.retries";
    --- End diff --
    
    We usually don't abbreviate configuration keys. Can you rename it to "CONFIG_KEY_CONNECTION_RETRIES" ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---