Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1941-flink@git.apache.org>
In-Reply-To: <git-pr-1941-flink@git.apache.org>
Subject: [GitHub] flink pull request: Flink 3750 fixed
Content-Type: text/plain
Message-Id: <20160504104003.308FDE9429@git1-us-west.apache.org>
Date: Wed,  4 May 2016 10:40:03 +0000 (UTC)
archived-at: Wed, 04 May 2016 10:47:16 -0000

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1941#discussion_r62019420
  
    --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/NumericColumnSplitsGenerator.java ---
    @@ -0,0 +1,63 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p/>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p/>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.api.java.io.jdbc.split;
    +
    +import org.apache.flink.api.java.io.QueryParamInputSplit;
    +
    +/** 
    + * 
    + * This splits generator assumes that the query has a BETWEEN constraint on a numeric column.
    + * The generated input splits will be of size equal to the configured fetchSize (maximum),
    + * ranging from the min value up to the max 
    + * 
    + * */
    +public class NumericColumnSplitsGenerator implements JDBCInputSplitsGenerator {
    --- End diff --
    
    I think ParameterValueProviders are very query specific. Not sure if it makes sense to provide default implementations. This class should be moved to the test scope, IMO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---