Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fhueske <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
References: <git-pr-1941-flink@git.apache.org>
In-Reply-To: <git-pr-1941-flink@git.apache.org>
Subject: [GitHub] flink pull request: Flink 3750 fixed
Content-Type: text/plain
Message-Id: <20160504102909.19724DFB79@git1-us-west.apache.org>
Date: Wed,  4 May 2016 10:29:09 +0000 (UTC)
archived-at: Wed, 04 May 2016 10:29:15 -0000

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1941#discussion_r62018432
  
    --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java ---
    @@ -139,12 +184,13 @@ public void close() throws IOException {
     	@Override
     	public boolean reachedEnd() throws IOException {
     		try {
    -			if (resultSet.isLast()) {
    -				close();
    +			if (!hasNext || resultSet.isLast()) {
    +				close();	
    --- End diff --
    
    I think `reachedEnd()` should not call `close()`. `close()` should be called by the `DataSourceTask` (or the other class handling the `InputFormat`)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---