flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yjshen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...
Date Tue, 03 May 2016 10:07:48 GMT
GitHub user yjshen opened a pull request:


    [FLINK-3754][Table]Add a validation phase before construct RelNode using TableAPI

    This PR aims at adding an extra phase of **validation** for plans generated from Table
API, matches the functionality of Calcite's Validator that are called during we execute an
query expressed in SQL String.
    In order to do this, I inserted a new layer between TableAPI and `RelNode` construction:
The `Logical Plan`.
    And the main procedure of validation work as follows:
    1. Constructing a logical plan node
    2. Do resolution using schema and `FunctionCatalog`
    3. Do validation on the type annotated logical plan node
    After we finish the validation successfully, it's safe to construct `RelNode`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yjshen/flink eager_validation

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1958
commit ec6bf418e065d836f5399275d4ab24b9c29ab0fe
Author: Yijie Shen <henry.yijieshen@gmail.com>
Date:   2016-04-13T08:46:58Z

    Add an extra validation phase before construct RelNode.
    Squash previous commits into single one for easier rebase.
    The eight previous commits are:
      make TreeNode extends Product
      wip expressions validation, should create expressions for functions next
      add functions for math and string
      wip move table api on logicalNode
      resolve and validate next
      fix bug in validator, merge eval, add doc
      resolve comments

commit d31a782475903b16f57fee819fc1ddb830aaa597
Author: Yijie Shen <henry.yijieshen@gmail.com>
Date:   2016-05-03T08:57:02Z

    do eager validation


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message