flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3978) Add hasBroadcastVariable method to RuntimeContext
Date Mon, 30 May 2016 12:42:12 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306604#comment-15306604

ASF GitHub Bot commented on FLINK-3978:

Github user zentol commented on the pull request:

    Looks good. +1

> Add hasBroadcastVariable method to RuntimeContext
> -------------------------------------------------
>                 Key: FLINK-3978
>                 URL: https://issues.apache.org/jira/browse/FLINK-3978
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.1.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>            Priority: Minor
>             Fix For: 1.1.0
> The javadocs for {{RuntimeContext}} state that {{getAccumulator}} "throws an exception
if the accumulator does not exist or if the accumulator exists, but with different type",
although {{AbstractRuntimeUDFContext}} does not throw an exception but will return null.
> The javadocs for {{getBroadcastVariable}} do not mention throwing an exception. Currently
the only way to handle a broadcast variable that that may or may not exist is to catch and
ignore the exception. Adding a  {{containsBroadcastVariable}} method to {{RuntimeContext}}
would make this explicit.

This message was sent by Atlassian JIRA

View raw message