flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3405) Extend NiFiSource with interface StoppableFunction
Date Mon, 30 May 2016 17:03:12 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306817#comment-15306817
] 

ASF GitHub Bot commented on FLINK-3405:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2047#discussion_r65093152
  
    --- Diff: flink-streaming-connectors/flink-connector-nifi/src/main/java/org/apache/flink/streaming/connectors/nifi/NiFiSource.java
---
    @@ -143,4 +144,13 @@ public void close() throws Exception {
     		client.close();
     	}
     
    + /**
    +	* {@inheritDoc}
    +	* <p>
    +	* Sets the {@link #isRunning} flag to {@code false}.
    +	*/
    +	@Override
    +	public void stop() {
    +		this.isRunning = false;
    --- End diff --
    
    @StephanEwen could you point me to the code where close() is called for a stopped source?


> Extend NiFiSource with interface StoppableFunction
> --------------------------------------------------
>
>                 Key: FLINK-3405
>                 URL: https://issues.apache.org/jira/browse/FLINK-3405
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming Connectors
>            Reporter: Matthias J. Sax
>            Assignee: Suneel Marthi
>             Fix For: 1.1.0, 1.0.4
>
>
> Nifi source is not stoppable right now. To make it stoppable, is must implement {{StoppableFunction}}.
Implementing method {{stop()}} must ensure, that the source stops receiving new messages from
Nifi and issues a final checkpoint. Afterwards, {{run()}} must return.
> When implementing this, keep in mind, that the gathered checkpoint might later be used
as a savepoint.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message