flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-3129) Add tooling to ensure interface stability
Date Fri, 27 May 2016 13:19:12 GMT

    [ https://issues.apache.org/jira/browse/FLINK-3129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304052#comment-15304052

ASF GitHub Bot commented on FLINK-3129:

Github user zentol commented on a diff in the pull request:

    --- Diff: flink-core/src/main/java/org/apache/flink/api/common/ExecutionConfig.java ---
    @@ -82,6 +82,10 @@
     	private static final long DEFAULT_RESTART_DELAY = 10000L;
    +	// This field was used as a key for storing the EC in the Job Configuration
    +	@Deprecated
    +	public static final String CONFIG_KEY = "runtime.config";
    --- End diff --
    this change belongs in the "Fix breaking changes in flink-core" commit, unless they will
be squashed.

> Add tooling to ensure interface stability
> -----------------------------------------
>                 Key: FLINK-3129
>                 URL: https://issues.apache.org/jira/browse/FLINK-3129
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Build System
>            Reporter: Robert Metzger
>            Assignee: Robert Metzger
> I would like to use this maven plugin: https://github.com/siom79/japicmp to automatically
ensure interface stability across minor releases.
> Ideally we have the plugin in place after Flink 1.0 is out, so that maven builds break
if a breaking change has been made.
> The plugin already supports downloading a reference release, checking the build and breaking
> Not yet supported are class/method inclusions based on annotations, but I've opened a
pull request for adding it.
> There are also issues with the resolution of the dependency with the annotations, but
I'm working on resolving those issues.

This message was sent by Atlassian JIRA

View raw message