flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2673) Scala API does not support Option type as key
Date Sun, 22 May 2016 11:51:13 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15295526#comment-15295526

ASF GitHub Bot commented on FLINK-2673:

GitHub user chiwanpark opened a pull request:


    [FLINK-2673] [type system] Add a comparator for Scala Option type

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    I've added `OptionTypeComparator` implementation, unit test cases based on `ComparatorTestBase`
and a simple integration test case in `JoinITCase`. I followed [Till's opinion](http://markmail.org/message/vk3t3vpc6j6zbldk)
about order of `None` and `Some` values.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chiwanpark/flink FLINK-2673

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2017
commit 485b6904013c23316a9f61d651b44e245e47c61c
Author: Chiwan Park <chiwanpark@apache.org>
Date:   2016-05-22T11:39:10Z

    [FLINK-2673] [core] Add a comparator for Scala Option type


> Scala API does not support Option type as key
> ---------------------------------------------
>                 Key: FLINK-2673
>                 URL: https://issues.apache.org/jira/browse/FLINK-2673
>             Project: Flink
>          Issue Type: Wish
>          Components: Scala API
>            Reporter: Till Rohrmann
>            Assignee: Chiwan Park
>            Priority: Minor
> The Scala API does not support the {{Option}} type as a key. It could be useful to allow
grouping on a field with this type.

This message was sent by Atlassian JIRA

View raw message