flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-2184) Cannot get last element with maxBy/minBy
Date Mon, 09 May 2016 11:58:12 GMT

    [ https://issues.apache.org/jira/browse/FLINK-2184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15276268#comment-15276268
] 

ASF GitHub Bot commented on FLINK-2184:
---------------------------------------

GitHub user gallenvara opened a pull request:

    https://github.com/apache/flink/pull/1975

    [FLINK-2184] Cannot get last element with maxBy/minBy.

    Thanks for contributing to Apache Flink. Before you open your pull request, please take
the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request.
For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your
changes.
    
    - [X] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [X] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    Extended the minBy/maxBy methods to support returning last element.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gallenvara/flink flink-2184

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1975.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1975
    
----
commit 8ae9bb689320a0b5b3fe199ecc61c62504ff0e7d
Author: gallenvara <gallenvara@126.com>
Date:   2016-05-09T11:51:24Z

    Extend minBy/maxBy methods to support returning last element.

----


> Cannot get last element with maxBy/minBy
> ----------------------------------------
>
>                 Key: FLINK-2184
>                 URL: https://issues.apache.org/jira/browse/FLINK-2184
>             Project: Flink
>          Issue Type: Improvement
>          Components: Scala API, Streaming
>            Reporter: Gábor Hermann
>            Priority: Minor
>
> In the streaming Scala API there is no method
> {{maxBy(int positionToMaxBy, boolean first)}}
> nor
> {{minBy(int positionToMinBy, boolean first)}}
> like in the Java API, where _first_ set to {{true}} indicates that the latest found element
will return.
> These methods should be added to the Scala API too, in order to be consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message