flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephan Ewen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-1827) Move test classes in test folders and fix scope of test dependencies
Date Mon, 30 May 2016 15:56:12 GMT

    [ https://issues.apache.org/jira/browse/FLINK-1827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15306783#comment-15306783
] 

Stephan Ewen commented on FLINK-1827:
-------------------------------------

I think a {{flink-test-utils}} project is very worthwhile, as part of the core Flink project.
It would be the right place to put extended test utility classes into.

I don't quite understand why tests should not depend on the "main" scope of the {{flink-test-utils}}
project. If you skip tests compilation completely, then {{flink-test-utils}} is still compiled,
but that is not a problem.

> Move test classes in test folders and fix scope of test dependencies
> --------------------------------------------------------------------
>
>                 Key: FLINK-1827
>                 URL: https://issues.apache.org/jira/browse/FLINK-1827
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 0.9
>            Reporter: Flavio Pompermaier
>            Priority: Minor
>              Labels: test-compile
>             Fix For: 1.1.0
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> Right now it is not possible to avoid compilation of test classes (-Dmaven.test.skip=true)
because some project (e.g. flink-test-utils) requires test classes in non-test sources (e.g.
scalatest_${scala.binary.version})
> Test classes should be moved to src/main/test (if Java) and src/test/scala (if scala)
and use scope=test for test dependencies



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message