flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3994] [ml, tests] Fix flaky KNN integration tests
Date Tue, 31 May 2016 15:18:22 GMT
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/2056
  
    There is actually a problem with the way the Scala Tests are written:
    
    The code in the class that is outside the "it should" clauses is executed before the "before"
function. That is why the tests go against a LocalEnvironment, rather than the test context
environment.
    
    So Chiwan's patch will actually fix it, only for different reasons than initially expected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message