flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: FLINK-3405: Extend NiFiSource with interface S...
Date Tue, 31 May 2016 09:41:06 GMT
Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/2047#issuecomment-222640704
  
    I would do one change here: Make the `isRunning` flag non transient, and set it to true
initially, rather than in open.
    
    That can act as a safeguard against very early stopping (before open is even completed),
were stop would set the flag to false, and open would set it back to true.
    
    I think the runtime does prevent open to happen after stop, but cannot hurt to guard this
in the source as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message