flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3923] [connector-kinesis] Unify configu...
Date Fri, 27 May 2016 21:00:01 GMT
Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/2016#issuecomment-222252000
  
    I have to admit that these changes were not necessary: https://github.com/apache/flink/commit/23d1cba72859339bd3ee8f877b031353380c87fb#diff-d34eb8418ccff3e2d59a3e660fed6cec
    I wanted to change it so that the code won't throw any exceptions if the provided value
is not correctly parseable. I didn't see that the verify method in the constructor is already
doing that.
    
    I'll add a follow up JIRA for adding configuration keys for all relevant fields in `KinesisProducerConfiguration`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message