flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2314] Make Streaming File Sources Persi...
Date Tue, 24 May 2016 13:45:11 GMT
Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2020#discussion_r64392589
  
    --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/StreamFaultToleranceTestBase.java
---
    @@ -104,8 +106,25 @@ public void runCheckpointedProgram() {
     			postSubmit();
     		}
     		catch (Exception e) {
    +			Throwable th = e;
    +			int depth = 0;
    +
    +			for (; depth < 20; depth++) {
    +				if (th instanceof SuccessException) {
    +					try {
    +						postSubmit();
    +					} catch (Exception e1) {
    +						e1.printStackTrace();
    --- End diff --
    
    Should we not forward the exception here? You introduced this block so that `postSubmit()`
also runs when the `SuccessException` was thrown, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message