flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aozturk <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3923] [connector-kinesis] Unify configu...
Date Mon, 23 May 2016 14:48:42 GMT
Github user aozturk commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2016#discussion_r64235578
  
    --- Diff: flink-streaming-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisProducer.java
---
    @@ -160,12 +168,13 @@ public void setCustomPartitioner(KinesisPartitioner<OUT> partitioner)
{
     	public void open(Configuration parameters) throws Exception {
     		super.open(parameters);
     
    -		KinesisProducerConfiguration config = new KinesisProducerConfiguration();
    -		config.setRegion(this.region);
    -		config.setCredentialsProvider(new StaticCredentialsProvider(new BasicAWSCredentials(this.accessKey,
this.secretKey)));
    +		KinesisProducerConfiguration producerConfig = new KinesisProducerConfiguration();
    +
    +		producerConfig.setRegion(configProps.getProperty(KinesisConfigConstants.CONFIG_AWS_REGION));
    +		producerConfig.setCredentialsProvider(AWSUtil.getCredentialsProvider(configProps));
     		//config.setCollectionMaxCount(1);
     		//config.setAggregationMaxCount(1);
    --- End diff --
    
    Sure, no need for a new JIRA I can add these keys while addressing your review. I am actually
willing to do more work on Kinesis connector. You can freely name things here, or create an
issue and assign to me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message