flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3836] Add LongHistogram accumulator
Date Thu, 19 May 2016 09:30:04 GMT
Github user StephanEwen commented on a diff in the pull request:

    --- Diff: flink-streaming-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/testutils/MockRuntimeContext.java
    @@ -148,6 +149,11 @@ public Histogram getHistogram(String name) {
    +	public LongHistogram getLongHistogram(String name) {
    --- End diff --
    I think we should try and not have utility methods for each accumulator type in the runtime
context - it becomes a lot otherwise. The methods for `getHistogram()` etc are also marked
as public evolving, because they may possibly be removed in the future.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message