flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: Flink 3750 fixed
Date Wed, 18 May 2016 13:32:23 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1941#discussion_r63702313
  
    --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
    @@ -48,17 +49,53 @@
     /**
      * InputFormat to read data from a database and generate Rows.
      * The InputFormat has to be configured using the supplied InputFormatBuilder.
    - * 
    - * In order to query the JDBC source in parallel, you need to provide a parameterized
    - * query template (i.e. a valid {@link PreparedStatement}) and a {@link ParameterValuesProvider}

    - * which provides binding values for the query parameters.
    - * 
    + * A valid RowTypeInfo must be properly configured in the builder, e.g.: </br>
    --- End diff --
    
    Thanks for the nice JavaDocs! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message