flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mxm <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3667] refactor client communication
Date Wed, 18 May 2016 10:59:40 GMT
Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1978#discussion_r63683193
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClient.java ---
    @@ -211,14 +191,41 @@ public void run() {
     		Runtime.getRuntime().addShutdownHook(clientShutdownHook);
     
     		isConnected = true;
    +
    +		logAndSysout("Waiting until all TaskManagers have connected");
    +
    +		while(true) {
    +			GetClusterStatusResponse status = getClusterStatus();
    +			if (status != null) {
    +				if (status.numRegisteredTaskManagers() < clusterDescriptor.getTaskManagerCount())
{
    +					logAndSysout("TaskManager status (" + status.numRegisteredTaskManagers() + "/"
    +						+ clusterDescriptor.getTaskManagerCount() + ")");
    +				} else {
    +					logAndSysout("All TaskManagers are connected");
    +					break;
    +				}
    +			} else {
    +				logAndSysout("No status updates from the YARN cluster received so far. Waiting ...");
    +			}
    +
    +			try {
    +				Thread.sleep(500);
    +			}
    +			catch (InterruptedException e) {
    +				LOG.error("Interrupted while waiting for TaskManagers");
    +				System.err.println("Thread is interrupted");
    +				Thread.currentThread().interrupt();
    --- End diff --
    
    This is the old code that was used for deployment. Though at a different place. Would
be good to make it interruptible and cleanup everything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message