flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rmetzger <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3667] refactor client communication
Date Wed, 18 May 2016 10:34:39 GMT
Github user rmetzger commented on a diff in the pull request:

    --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
    @@ -830,53 +797,30 @@ else if (result instanceof DisposeSavepointFailure) {
     	//  Interaction with programs and JobManager
     	// --------------------------------------------------------------------------------------------
    -	protected int executeProgramDetached(PackagedProgram program, Client client, int parallelism)
    -		LOG.info("Starting execution of program");
    +	protected int executeProgram(PackagedProgram program, Client client, int parallelism)
    +		logAndSysout("Starting execution of program");
     		JobSubmissionResult result;
     		try {
    -			result = client.runDetached(program, parallelism);
    --- End diff --
    It seems that the runDetached is only used in the `DetachedEnvironment`. Maybe we can
use the setter-variant there as well to get rid of the method completely.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message