flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-1979] Add logistic loss, hinge loss and...
Date Tue, 17 May 2016 12:03:15 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1985#discussion_r63509381
  
    --- Diff: flink-libraries/flink-ml/src/main/scala/org/apache/flink/ml/optimization/GradientDescent.scala
---
    @@ -272,7 +272,7 @@ abstract class GradientDescent extends IterativeSolver {
       * The regularization function is `1/2 ||w||_2^2` with `w` being the weight vector.
       */
     class GradientDescentL2 extends GradientDescent {
    -
    +  //TODO(skavulya): Pass regularization penalty as a parameter
    --- End diff --
    
    Is this TODO still valid? If so, can we resolve it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message