flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3754][Table]Add a validation phase befo...
Date Tue, 10 May 2016 16:19:31 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1958#discussion_r62703535
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/TableEnvironment.scala
---
    @@ -152,13 +160,13 @@ abstract class TableEnvironment(val config: TableConfig) {
         *
         * @param name The name under which the table is registered.
         * @param table The table to register in the catalog
    -    * @throws TableException if another table is registered under the provided name.
    +    * @throws ValidationException if another table is registered under the provided name.
         */
    -  @throws[TableException]
    +  @throws[ValidationException]
       protected def registerTableInternal(name: String, table: AbstractTable): Unit = {
     
         if (isRegistered(name)) {
    -      throw new TableException(s"Table \'$name\' already exists. " +
    +      throw new ValidationException(s"Table \'$name\' already exists. " +
    --- End diff --
    
    Yes, that's a good point


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message