flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vasia <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...
Date Fri, 06 May 2016 11:48:30 GMT
Github user vasia commented on the pull request:

    https://github.com/apache/flink/pull/1956#issuecomment-217419465
  
    Hi @gallenvara, @greghogan,
    
    - If it's possible to return both the hub and the authority value, I'd prefer that.
    
    - GSA iterations allow setting the edge direction as Greg suggested. I'm not sure how
much of a difference the combiner would make. Also, we've seen that for some graphs scatter-gather
performs better. Personally, I would be fine with a first scatter-gather version of the algorithm.
We can run some tests to see whether GSA would be faster later.
    
    - I agree that edge values should be internally set to `NullValue` if not used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message