flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request: FLINK-3650 Add maxBy/minBy to Scala DataSet AP...
Date Fri, 06 May 2016 09:59:01 GMT
Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-java/src/main/java/org/apache/flink/api/java/functions/SelectByMinFunction.java
    @@ -72,8 +73,8 @@ public T reduce(T value1, T value2) throws Exception {
     		for (int position : fields) {
     			// Save position of compared key
     			// Get both values - both implement comparable
    -			Comparable comparable1 = value1.getFieldNotNull(position);
    -			Comparable comparable2 = value2.getFieldNotNull(position);
    +			Comparable comparable1 = ((Tuple)value1).getFieldNotNull(position);
    --- End diff --
    The `CaseClassTypeInfo` is the type information which is created for Scala tuples, if
I'm not mistaken. And all Scala tuples are of type `Product`. With that you should be able
to adapt the `SelectByMax/MinFunction`.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message