flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fpompermaier <...@git.apache.org>
Subject [GitHub] flink pull request: Flink 3750 fixed
Date Wed, 04 May 2016 11:12:54 GMT
Github user fpompermaier commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1941#discussion_r62022375
  
    --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
    @@ -157,14 +203,25 @@ public boolean reachedEnd() throws IOException {
     	 * @throws java.io.IOException
     	 */
     	@Override
    -	public OUT nextRecord(OUT tuple) throws IOException {
    +	public Row nextRecord(Row row) throws IOException {
     		try {
    -			resultSet.next();
    -			if (columnTypes == null) {
    -				extractTypes(tuple);
    +			hasNext = resultSet.next();
    +			if(!hasNext) {
    +				return null;
    +			}
    +			try{
    +				//This throws a NPE when the TypeInfo is not passed to the InputFormat,
    +				//i.e. KryoSerializer used to generate the passed row
    +				row.productArity();
    +			}catch(NullPointerException npe) {
    --- End diff --
    
    Ok thanks! I saw that there's a discussion about a formatter for IntelliJ...it would be
great to have such a formatter also for Eclipse :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message