flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: Flink 3750 fixed
Date Wed, 04 May 2016 10:36:56 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1941#discussion_r62019142
  
    --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCInputFormat.java
---
    @@ -314,7 +262,8 @@ public static JDBCInputFormatBuilder buildJDBCInputFormat() {
     
     		public JDBCInputFormatBuilder() {
     			this.format = new JDBCInputFormat();
    -			this.format.resultSetType = ResultSet.TYPE_FORWARD_ONLY;
    +			// The 'isLast' method is only allowed on scroll cursors.
    +			this.format.resultSetType = ResultSet.TYPE_SCROLL_INSENSITIVE;
    --- End diff --
    
    We can use `TYPE_FORWARD_ONLY` if we remove `ResultSet.isLast()`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message