flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request: Flink 3750 fixed
Date Wed, 04 May 2016 10:24:58 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1941#discussion_r62018058
  
    --- Diff: flink-batch-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/split/JDBCInputSplitsGenerator.java
---
    @@ -15,17 +15,14 @@
      * See the License for the specific language governing permissions and
      * limitations under the License.
      */
    -package org.apache.flink.api.java.io.jdbc;
    +package org.apache.flink.api.java.io.jdbc.split;
     
    -import java.io.OutputStream;
    +import java.io.Serializable;
     
    -@SuppressWarnings("unused")
    -/**
    - * Utility class to disable derby logging
    - */
    -public class DerbyUtil {
    -	public static final OutputStream DEV_NULL = new OutputStream() {
    -		public void write(int b) {
    -		}
    -	};
    +import org.apache.flink.api.java.io.QueryParamInputSplit;
    +
    +public interface JDBCInputSplitsGenerator extends Serializable {
    --- End diff --
    
    I think we should hide the concept of input splits from users. Can you rename the interface
to `ParameterValueProvider`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message