flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gallenvara <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-2044] [gelly] Implementation of Gelly H...
Date Tue, 03 May 2016 11:02:37 GMT
Github user gallenvara commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1956#discussion_r61865225
  
    --- Diff: flink-libraries/flink-gelly/src/main/java/org/apache/flink/graph/library/HITSAlgorithm.java
---
    @@ -0,0 +1,194 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.graph.library;
    +
    +import org.apache.flink.api.common.aggregators.DoubleSumAggregator;
    +import org.apache.flink.api.java.DataSet;
    +
    +import org.apache.flink.graph.Edge;
    +import org.apache.flink.graph.EdgeDirection;
    +import org.apache.flink.graph.Graph;
    +import org.apache.flink.graph.GraphAlgorithm;
    +import org.apache.flink.graph.Vertex;
    +import org.apache.flink.graph.spargel.MessageIterator;
    +import org.apache.flink.graph.spargel.MessagingFunction;
    +import org.apache.flink.graph.spargel.ScatterGatherConfiguration;
    +import org.apache.flink.graph.spargel.VertexUpdateFunction;
    +import org.apache.flink.types.DoubleValue;
    +
    +/**
    + * This is an implementation of HITS algorithm, using a scatter-gather iteration.
    + * The user can define the maximum number of iterations. HITS algorithm is determined
by two parameters,
    + * hubs and authorities. A good hub represented a page that pointed to many other pages,
and a good authority
    + * represented a page that was linked by many different hubs. The implementation assumes
that the two value on
    + * every vertex are the same at the beginning.
    + * <p>
    + * If the number of vertices of the input graph is known, it should be provided as a
parameter
    + * to speed up computation. Otherwise, the algorithm will first execute a job to count
the vertices.
    + */
    +public class HITSAlgorithm<K> implements GraphAlgorithm<K, Double, Double, DataSet<Vertex<K,
Double>>> {
    --- End diff --
    
    The edge value is not used throughout the process. It would be better to set to `NullValue`
as hard code, IMO.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message