flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ramkrish86 <...@git.apache.org>
Subject [GitHub] flink pull request: FLINK-3650 Add maxBy/minBy to Scala DataSet AP...
Date Mon, 02 May 2016 17:19:12 GMT
Github user ramkrish86 commented on a diff in the pull request:

    --- Diff: flink-scala/src/test/scala/org/apache/flink/api/operator/MaxByOperatorTest.scala
    @@ -0,0 +1,110 @@
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.api.operator
    +import org.apache.flink.api.common.InvalidProgramException
    +import org.apache.flink.api.common.typeinfo.BasicTypeInfo
    +import org.apache.flink.api.java.tuple.{Tuple, Tuple5}
    +import org.apache.flink.api.java.typeutils.TupleTypeInfo
    +import org.apache.flink.api.scala._
    +import org.junit.Test
    +import org.junit.Assert;
    +class MaxByOperatorTest {
    +  private val emptyTupleData = List[Tuple5[Integer, Long, String, Long, Integer]]()
    +  private val customTypeData = List[CustomType](new CustomType())
    +  private val tupleTypeInfo: TupleTypeInfo[Tuple5[Integer, Long, String, Long, Integer]]
    --- End diff --
    Sorry. I am not sure on this. Can you give some examples?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message