flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljoscha <...@git.apache.org>
Subject [GitHub] flink pull request: [FLINK-3854] Support Avro key-value rolling si...
Date Mon, 02 May 2016 12:42:49 GMT
Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1953#issuecomment-216225261
  
    AFAIK the failing build is "normal" right now, we have some problem with the travis caches.
    
    The PR looks very good, @rmetzger what are you saying about copying the code from avro-mapred
instead of adding it as a dependency? I think it's fine because we don't want such a big dependency.
My only concern is that the binary format might go out of sync. But then we can adapt, I think.
    
    The tests also look good, I don't think a separate exactly-once test is needed.
    
    Did you also test this in a cluster and/or on some real-world data?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message