Mailing-List: contact issues-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
From: fpompermaier <git@git.apache.org>
To: issues@flink.incubator.apache.org
Reply-To: issues@flink.incubator.apache.org
Message-ID: <git-pr-1885-flink@git.apache.org>
Subject: [GitHub] flink pull request: Improved JDBCInputFormat (FLINK-3750)
 and othe...
Content-Type: text/plain
Date: Thu, 14 Apr 2016 12:26:39 +0000 (UTC)

GitHub user fpompermaier opened a pull request:

    https://github.com/apache/flink/pull/1885

    Improved JDBCInputFormat (FLINK-3750) and other fixes

    Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful description of your changes.
    
    - [ X ] General
      - The pull request references the related JIRA issue
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message
    
    - [ X ] Documentation (**Except web site**)
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ X ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed
    
    -------------------------------------
    Improved JDBCInputFormat (FLINK-3750), fixed test Exceptions in the
    @AfterClass due to unclosed resources and removed unnecessary close()
    
    Still to discuss how to manage the several TODO added in the code

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fpompermaier/flink FLINK-3750

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1885.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1885
    
----
commit af2b74f707bf7cbabdbfe14b5c17be68c252aa22
Author: Flavio Pompermaier <f.pompermaier@gmail.com>
Date:   2016-04-14T12:18:06Z

    Improved JDBCInputFormat (FLINK-3750), fixed test Exceptions in the
    @AfterClass due to unclosed resources and removed unnecessary close()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---