Return-Path: X-Original-To: apmail-flink-issues-archive@minotaur.apache.org Delivered-To: apmail-flink-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 32A751895E for ; Thu, 28 Apr 2016 21:07:13 +0000 (UTC) Received: (qmail 4038 invoked by uid 500); 28 Apr 2016 21:07:13 -0000 Delivered-To: apmail-flink-issues-archive@flink.apache.org Received: (qmail 3950 invoked by uid 500); 28 Apr 2016 21:07:13 -0000 Mailing-List: contact issues-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list issues@flink.apache.org Received: (qmail 3929 invoked by uid 99); 28 Apr 2016 21:07:13 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Apr 2016 21:07:13 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id DEE822C1F5D for ; Thu, 28 Apr 2016 21:07:12 +0000 (UTC) Date: Thu, 28 Apr 2016 21:07:12 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@flink.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (FLINK-3845) Gelly allows duplicate vertices in Graph.addVertices MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLINK-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262995#comment-15262995 ] ASF GitHub Bot commented on FLINK-3845: --------------------------------------- GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/1949 [FLINK-3845] [gelly] Gelly allows duplicate vertices in Graph.addVertices Vertex sets are now merged with a cogroup so that a new Vertex is only added to the Graph when no existing Vertex exists with the same label. You can merge this pull request into a Git repository by running: $ git pull https://github.com/greghogan/flink 3845_gelly_allows_duplicate_vertices_in_graph_addvertices Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/1949.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1949 ---- commit 51a4733d0a52e21093e79b326e521d386f11b95d Author: Greg Hogan Date: 2016-04-28T15:34:41Z [FLINK-3845] [gelly] Gelly allows duplicate vertices in Graph.addVertices Vertex sets are now merged with a cogroup so that a new Vertex is only added to the Graph when no existing Vertex exists with the same label. ---- > Gelly allows duplicate vertices in Graph.addVertices > ---------------------------------------------------- > > Key: FLINK-3845 > URL: https://issues.apache.org/jira/browse/FLINK-3845 > Project: Flink > Issue Type: Bug > Components: Gelly > Affects Versions: 1.1.0 > Reporter: Greg Hogan > Assignee: Greg Hogan > Fix For: 1.1.0 > > > Gelly performs a {{DataSet}} union then calls {{distinct()}} which keeps vertices with the same label but different values. This should be replaced with one of the join operators. -- This message was sent by Atlassian JIRA (v6.3.4#6332)